Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Cinder storage backend implementation and accompanying unit tests for an IBMStorage-based charm, integrating it into the existing backend test matrix.
Changes:
- Introduce
IbmibmstorageBackendandIbmibmstorageConfigundersunbeam.storage.backends.ibmibmstorage. - Add backend-specific unit tests and hook the new backend into shared backend fixtures and uniqueness checks.
- Extend common backend tests to include the new backend in parametrized runs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
sunbeam-python/sunbeam/storage/backends/ibmibmstorage/backend.py |
New IBMStorage backend + Pydantic config model (including enums/options). |
sunbeam-python/sunbeam/storage/backends/ibmibmstorage/__init__.py |
Package initializer and module docstring for the new backend. |
sunbeam-python/tests/unit/sunbeam/storage/backends/test_ibmibmstorage.py |
New unit tests for backend identity, secrets, and protocol validation. |
sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py |
Extend shared uniqueness/expectation tests to include the new backend. |
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py |
Add fixtures for the new backend and include it in the any_backend parametrization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahmad-can
force-pushed
the
feature/generate-ibmibmstorage-charm
branch
from
5aa3f46 to
dec8049
Compare
ahmad-can
force-pushed
the
feature/generate-ibmibmstorage-charm
branch
from
fc20dc4 to
cec5a43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/983832